-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Upgrade to Node 20 #2244
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2244 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 195 195
Lines 21603 21603
Branches 1936 1936
=======================================
Hits 20549 20549
Misses 786 786
Partials 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for this fix @BilalQamar95 ! Works perfectly.
- I tested this by building and running this branch on my tutor dev stack, and verifying that the XBlock still works as expected.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
@BilalQamar95 Do we need a version bump for this? |
I don't think a version bump is required for this change, as the upgrade from Node v18 to v20 is purely a build environment update and doesn’t involve any major package upgrades or breaking changes to the codebase. |
Description
package-lock.json
with nodev20
and NPM10
..nvmrc
tov20
Second step in the Node 20 upgrade process, See the tracking issue for further information.